Skip to content

SSP 2.5 compatibility#333

Merged
cicnavi merged 14 commits intomasterfrom
feature/ssp25-compat
Mar 16, 2026
Merged

SSP 2.5 compatibility#333
cicnavi merged 14 commits intomasterfrom
feature/ssp25-compat

Conversation

@tvdijen
Copy link
Member

@tvdijen tvdijen commented Mar 14, 2026

conformance-tests fail because of: cirrusidentity/docker-simplesamlphp#22

@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

❌ Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.85%. Comparing base (ac4a475) to head (a39e346).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Services/LoggerService.php 0.00% 8 Missing ⚠️
src/Utils/FingerprintGenerator.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #333      +/-   ##
============================================
+ Coverage     53.81%   53.85%   +0.04%     
  Complexity     1500     1500              
============================================
  Files           141      141              
  Lines          6060     6057       -3     
============================================
+ Hits           3261     3262       +1     
+ Misses         2799     2795       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdijen tvdijen force-pushed the feature/ssp25-compat branch 5 times, most recently from 88da786 to 48a0f1f Compare March 14, 2026 19:42
@tvdijen tvdijen requested a review from cicnavi March 14, 2026 20:06
@tvdijen tvdijen force-pushed the feature/ssp25-compat branch 3 times, most recently from 2c0a439 to 46be6ba Compare March 14, 2026 20:20
@tvdijen tvdijen force-pushed the feature/ssp25-compat branch from 46be6ba to a8edb37 Compare March 15, 2026 12:17
Copy link
Collaborator

@cicnavi cicnavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping into this, Tim!

I've used my fork of CirrussID SSP Docker containers to run conformance tests for now. Will switch once Patrick bumps his images...

@cicnavi cicnavi merged commit bb8aeac into master Mar 16, 2026
18 of 19 checks passed
@cicnavi cicnavi deleted the feature/ssp25-compat branch March 16, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants